Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count_forks option for Lang cards and hide_border option for Repo cards #480

Closed
wants to merge 11 commits into from

Conversation

Bas950
Copy link
Contributor

@Bas950 Bas950 commented Sep 20, 2020

/api/top-langs/?username=USER
image
/api/top-langs/?username=USER&count_forks=true
image

/api/pin/?username=USER&repo=REPO
image
/api/pin/?username=USER&repo=REPO&hide_border=true
image
(Hard to see... but it is removed.)

/api/top-langs/?username=USER&count_forks=true
image
/api/top-langs/?username=USER&count_forks=true&exclude_repo=REPO
image

Added prettier configs so users don't change the whole spacings.

closes #468

countForks default = false

Looks like my "Prettier" extension actived too...
Looks like my "Prettier" extension actived too...
@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #480 into master will decrease coverage by 0.00%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   91.82%   91.82%   -0.01%     
==========================================
  Files          19       19              
  Lines         575      587      +12     
  Branches      159      163       +4     
==========================================
+ Hits          528      539      +11     
- Misses         41       42       +1     
  Partials        6        6              
Impacted Files Coverage Δ
api/pin.js 91.30% <ø> (ø)
src/common/retryer.js 72.22% <66.66%> (ø)
src/fetchers/top-languages-fetcher.js 97.56% <93.33%> (-2.44%) ⬇️
api/top-langs.js 94.11% <100.00%> (ø)
src/cards/repo-card.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e73a00...ceaa405. Read the comment docs.

Comment on lines 96 to 120
};
const svgStars =
stargazers.totalCount > 0 &&
iconWithLabel(icons.star, totalStars, "stargazers");
const svgForks =
forkCount > 0 && iconWithLabel(icons.fork, totalForks, "forkcount");

const starAndForkCount = FlexLayout({
items: [svgStars, svgForks],
gap: 65
}).join("");

const card = new Card({
title: header,
titlePrefixIcon: icons.contribs,
width: 400,
height,
colors: {
titleColor,
textColor,
iconColor,
bgColor
}
});

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure nothing else changes other than the code you want. all the code is messed up. make sure your codeeditor does not have wrong tabs/space configs

Copy link
Contributor Author

@Bas950 Bas950 Sep 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the spacings

@anuraghazra
Copy link
Owner

Hey @Bas950 i really would appreciate if you can add the exclude_repo feature on a different PR, let's add one feature per PR.

@Bas950 Bas950 mentioned this pull request Sep 24, 2020
@Bas950
Copy link
Contributor Author

Bas950 commented Sep 24, 2020

Hey @Bas950 i really would appreciate if you can add the exclude_repo feature on a different PR, let's add one feature per PR.

Alright, will make different PRs for each feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't show any languages and can't remove border from repo card
2 participants